Simplified error reporting paths, reduced number of popups

Christopher Stone
1 parent 41e2a564
Showing 2 changed files with 6 additions and 11 deletions Show diff stats
robots/little_john/telemetry/code/monitor/graph_plotter_rewrite.py
robots/little_john/telemetry/code/monitor/serialselect.py
@@ -26,14 +26,8 @@ logging.info(&quot;Logging system active&quot;)
  
 datafeed = selectserial()
  
-if type(datafeed) is str:
-    message = "Failed to open serial port: " + datafeed
-    easygui.msgbox(message, "Fatal error")
-    logging.critical(message)
-    sys.exit()
-elif datafeed == None:
-    message = "Failed to open serial port for unknown reason!"
-    easygui.msgbox(message, "Fatal error")
+if datafeed == None:
+    message = "Failed to open serial port"
     logging.critical(message)
     sys.exit()
  
@@ -40,12 +40,12 @@ def selectserial():
         title = "Found multiple serial ports!"
         serialport = easygui.choicebox(message, title, targetdevs)
         if serialport == None:
-            return "User cancelled selection dialogue"
+            logging.info("User cancelled selection dialogue")
+            return None
     else:
         logging.info("Only found one likely serial device: " + targetdevs[0])
         serialport = targetdevs[0]
  
-
     try:
         datafeed = serial.Serial(
         port=serialport,
@@ -59,4 +59,5 @@ def selectserial():
         logging.info("Sucessfully opened " + serialport + " as data source!")
         return datafeed
     except Exception as e:
-        return str(e)
+        logging.critical(str(e))
+        return None